[OE-core] why does sysfsutils-2.1.0.bb set S = "${WORKDIR}/sysfsutils-${PV}"?

[Paul Eggleton]

On Monday 26 October 2015 06:23:09 Robert P. J. Day wrote:
> On Fri, 23 Oct 2015, Paul Eggleton wrote:
> 
> ... me snipped ...
> 
> > I don't think so, it appears that line goes way back to the initial
> > population of the repository. Looks like we could just drop it.
> 
>   it *looks* like there are a number of lines like that in oe-core
> that are superfluous ... some samples (which i have not verified, i
> just selected from brief visual inspection):
> 
> recipes-bsp/hostap/hostap-utils.inc:S = "${WORKDIR}/hostap-utils-${PV}"
> recipes-bsp/pcmciautils/pcmciautils.inc:S = "${WORKDIR}/pcmciautils-${PV}"
> recipes-connectivity/openssl/openssl.inc:S = "${WORKDIR}/openssl-${PV}"
> recipes-core/sysvinit/sysvinit_2.88dsf.bb:S = "${WORKDIR}/sysvinit-${PV}"
> recipes-core/glib-2.0/glib.inc:S = "${WORKDIR}/glib-${PV}"
> recipes-core/sysfsutils/sysfsutils_2.1.0.bb:S =
> "${WORKDIR}/sysfsutils-${PV}" recipes-devtools/mtools/mtools_3.9.9.bb:S =
> "${WORKDIR}/mtools-${PV}" recipes-devtools/intltool/intltool.inc:S =
> "${WORKDIR}/intltool-${PV}" recipes-devtools/git/git.inc:S =
> "${WORKDIR}/git-${PV}"
> recipes-extended/psmisc/psmisc.inc:S = "${WORKDIR}/psmisc-${PV}"
> recipes-extended/net-tools/net-tools_1.60-26.bb:S =
> "${WORKDIR}/net-tools-1.60" 
> recipes-gnome/gtk+/gtk+3_3.16.6.bb:S =
> "${WORKDIR}/gtk+-${PV}"
> recipes-kernel/oprofile/oprofile_1.1.0.bb:S = "${WORKDIR}/oprofile-${PV}"
> recipes-multimedia/libid3tag/libid3tag_0.15.1b.bb:S =
> "${WORKDIR}/libid3tag-${PV}" ... etc etc ...
> 
> and probably lots more. do i have at least the right understanding
> that any setting of S which eventally equates to
> ${WORKDIR}/${BPN}-${PV} serves no useful purpose? (not sure about
> *-native recipes, though, i have to take a closer look at those to see
> if they fit the pattern.)

Now, you really need to be careful with this - in some cases these files are 
included from other recipes where PN is not the same as it would be in the 
standard recipe; there it is deliberate and "cleaning it up" would actually 
break the other recipe. Additionally I can see above, net-tools isn't a 
candidate because the version part is not the same ("1.60" vs "1.60-26"). 
Every recipe will need to be checked.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre