[OE-core] [oe-commits] Alex Franco : Fix mode +st on TMPDIR when creating it

[Richard Purdie]

On Tue, 2015-09-01 at 16:47 -0700, Christopher Larson wrote:
> 
> On Tue, Sep 1, 2015 at 4:11 PM, Alex Franco
> <alejandro.franco at linux.intel.com> wrote:
>         I gather the original reason (for the sanity test, as well as
>         these changes) is that it is better for everything under
>         BUILDDIR - and certainly TMPDIR to be owned by the user
>         running bitbake and have standard permissions, the sticky bit
>         itself would prevent a user running bitbake, even with +rwx
>         permissions, from making changes to items it might need to
>         manipulate, if those are not owned by this user. Similarly
>         setuid and setgid might propagate user/group ownerships
>         different from the user bitbake is running as, into BUILDDIR
>         and TMPDIR (and items therein).
>         
>         For more info take a look at:
>         https://bugzilla.yoctoproject.org/show_bug.cgi?id=7669
>         
>         Perhaps there are more pressing reasons, perhaps Christopher
>         Larson can comment a bit on this.
> 
> Indeed, the g+s can flow down into the files put into the packages,
> and then into the rootfs. I ran into a this problem quite a bit, since
> my project areas are in a g+s area to keep the files accessible to the
> group.


There is actually another problem here. The -R means if you do this to
an existing build directory, it takes around 10 mins on the machine I
just rebooted with a cold cache. We need to lose the -R there.

Cheers,

Richard