[OE-core] [PATCH 1/1] fs-perms.txt: fix ROOT_HOME's permission
Dan McGregor
danismostlikely at gmail.com
Fri Apr 8 03:49:49 UTC 2016
On 7 April 2016 at 18:47, Robert Yang <liezhi.yang at windriver.com> wrote:
>
>
> On 04/07/2016 11:55 PM, Dan McGregor wrote:
>>
>> On 7 April 2016 at 07:46, Robert Yang <liezhi.yang at windriver.com> wrote:
>>>
>>>
>>>
>>> On 04/07/2016 09:30 PM, Dan McGregor wrote:
>>>>
>>>>
>>>> On 7 April 2016 at 01:50, Robert Yang <liezhi.yang at windriver.com> wrote:
>>>>>
>>>>>
>>>>> It should be 0700 rather than 0755.
>>>>>
>>>>> Reported-by: Charles Chan <charles.wh.chan at gmail.com>
>>>>> Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
>>>>> ---
>>>>> meta/files/fs-perms.txt | 1 +
>>>>> 1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
>>>>> index 109cbe5..1d74da7 100644
>>>>> --- a/meta/files/fs-perms.txt
>>>>> +++ b/meta/files/fs-perms.txt
>>>>> @@ -51,6 +51,7 @@ ${localstatedir}/lock link /run/lock
>>>>> ${localstatedir}/tmp link volatile/tmp
>>>>>
>>>>> /home 0755 root root false - - -
>>>>> +${ROOT_HOME} 0700 root root false - - -
>>>>
>>>>
>>>>
>>>> I'd like to see this in the section labelled "Special permissions from
>>>> base-files" around line 58. I think that makes it more clear that this
>>>> is a special permission setting.
>>>
>>>
>>>
>>> Thanks, updated in the repo:
>>>
>>> git://git.openembedded.org/openembedded-core-contrib rbt/home
>>>
>>>
>>> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home
>>>
>>>
>>> commit ccc59f44f5fc6c6ccef6b0fed58b0d582c9ee32b
>>> Author: Robert Yang <liezhi.yang at windriver.com>
>>> Date: Tue Apr 5 22:34:25 2016 -0700
>>>
>>> fs-perms.txt: fix ROOT_HOME's permission
>>>
>>> It should be 0700 rather than 0755.
>>>
>>> Reported-by: Charles Chan <charles.wh.chan at gmail.com>
>>> Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
>>>
>>> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
>>> index 109cbe5..6c1083c 100644
>>> --- a/meta/files/fs-perms.txt
>>> +++ b/meta/files/fs-perms.txt
>>> @@ -59,6 +59,7 @@ ${localstatedir}/local 0755 root
>>> root
>>> false - - -
>>> # Set 1777
>>> /tmp 01777 root root false - - -
>>> ${localstatedir}/volatile/tmp 01777 root root false - - -
>>> +${ROOT_HOME} 0700 root root false - - -
>>>
>>
>> Thanks, this is the right track, but this implies that ${ROOT_HOME}
>> should be mode 1777, how about:
>>
>> +
>> +# Set 700
>> +${ROOT_HOME} 0700 root root false - - -
>
>
> Thanks, updated in the repo:
>
> git://git.openembedded.org/openembedded-core-contrib rbt/home
>
> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home
>
>
> commit 5d0c64fd55edc957d8fb6340c9842bf8498a485d
> Author: Robert Yang <liezhi.yang at windriver.com>
> Date: Tue Apr 5 22:34:25 2016 -0700
>
> fs-perms.txt: fix ROOT_HOME's permission
>
> It should be 0700 rather than 0755.
>
> Reported-by: Charles Chan <charles.wh.chan at gmail.com>
> Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
>
> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
> index 109cbe5..3d00e86 100644
> --- a/meta/files/fs-perms.txt
> +++ b/meta/files/fs-perms.txt
> @@ -60,6 +60,9 @@ ${localstatedir}/local 0755 root root
> false - - -
> /tmp 01777 root root false - - -
> ${localstatedir}/volatile/tmp 01777 root root false - - -
>
> +# Set 0700
> +${ROOT_HOME} 0700 root root false - - -
> +
>
> # Set 755-lsb
> /srv 0755 root root false - - -
>
Looks good to me.
>
> // Robert
>
>>
>>> # Set 755-lsb
>>> /srv 0755 root root false - - -
>>>
>>>
>>> // Robert
>>>
>>>
>>>>
>>>>
>>>>> /srv 0755 root root false - - -
>>>>> ${prefix}/src 0755 root root false - - -
>>>>> ${localstatedir}/local 0755 root root false - - -
>>>>> --
>>>>> 2.8.0
>>>>>
>>>>> --
>>>>> _______________________________________________
>>>>> Openembedded-core mailing list
>>>>> Openembedded-core at lists.openembedded.org
>>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>>
>>>>
>>>>
>>>
>>
>
More information about the Openembedded-core
mailing list