[OE-core] [PATCHv2 1/1] Revert "useradd.bbclass: remove user/group created by the package in clean* task"

[Otavio Salvador]

On Tue, Apr 12, 2016 at 11:54 AM, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> On Tue, 2016-04-12 at 15:18 +0200, Peter Kjellerstedt wrote:
>> Removal of users/group when cleansstating a recipe as implemented
>> here
>> totally breaks when multiple recipes install the same user/groups.
>>
>> This reverts commit b5304ce438666a7418746f4ddd32703ae3188089.
>>
>> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt at axis.com>
>> ---
>>  meta/classes/sstate.bbclass  |  5 -----
>>  meta/classes/useradd.bbclass | 29 -----------------------------
>>  2 files changed, 34 deletions(-)
>
> This is one of these situations where we can't win.
>
> Without this code, there is no way to clean up these users out the
> sysroot. Having to tell people to "wipe TMPDIR" when the parameters
> used to create a user change for example is rather bad. It also has bad
> implications for build determinism and the expectation that a "clean"
> undoes the changes a recipe makes.
>
> Have we ever documented we support the same user being created by
> multiple recipes?
>
> I'm open to proposals about how to fix this but an outright revert
> doesn't seem like the right thing to do. Making it optional so you can
> disable it for your multiple recipes case would perhaps be a better
> option for example.

I am not against the change by the timing; it should be merged in
master as soon it is open for 2.2 work.


-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750