[OE-core] [PATCHv2 1/1] Revert "useradd.bbclass: remove user/group created by the package in clean* task"

[Richard Purdie]

On Wed, 2016-04-13 at 17:29 +0100, Richard Purdie wrote:
> There is a comparatively neat way we could use pkgdata to track the
> provider of a given user, specifically:
> 
> http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rpurdie/w
> ip
> &id=5cd646ea185eaafaa341f26310f2eddc75766175
> 
> The above is a quick patch I've just put together which illustrates
> what could be done so that the user gets better warnings about
> conflicting users. It needs cleaning up but thought it worth sharing
> now as if might give some ideas.
> 
> This is in keeping with how bitbake detects multiple providers of the
> same thing.

http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rpurdie/wip
&id=a362e6da0eec1f7a7d4db19d47f16b1c729562ba

is an improved version.

> > Here I must show my lack of knowledge. How and where should I go
> > about 
> > adding a regression test that verifies the support for that
> > multiple 
> > recipes can add the same user/group? Since this does not test a 
> > specific recipe, but rather a part of the build framework, I do not
> > know if, e.g., ptest is applicable (of which I have no experience 
> > either).
> 
> oe-selftest would be the place to add something like this, see the
>  /meta/lib/oeqa/selftest directory. We could add some test useradd
> recipes to meta-selftest.

http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rpurdie/wip
&id=23134a7d837bc7985ba8e7069d405913c2055a04

is a really simplistic new selftest for useradd. It does however test
the bug the original patch fixes. There are clearly a much wider range
of things it could test, I just wanted to show this isn't hard.

Cheers,

Richard