[OE-core] [PATCH 1/3] create-pull-request: create branch on remote if not found
Bruce Ashfield
bruce.ashfield at gmail.com
Tue Apr 19 03:00:47 UTC 2016
On Mon, Apr 18, 2016 at 10:45 PM, Robert Yang <liezhi.yang at windriver.com>
wrote:
> Before this patch, we need two steps to create PULL:
> * Step 1, create branch:
> $ git push <contrib> <local_branch>:<remote_branch>
> * Step 2, create PULL:
> $ create-pull-request -u <contrib> -l <local_branch> -b <remote_branch>
> -r <local_branch>~<n>
>
> We can see that the args used in step 1 are in step 2, so we can use
> create-pull-request to create the branch if not found to simplify the
> steps.
>
I think this needs to be optional. When I'm running this script, I'm just
looking to have something
I've already pushed locally dumped. If I mess up, and don't have the branch
that I've used
pushed to my remote already (or for whatever reason want/need different
branches .. which
was broken in previous updates to the script .. grrr), I don't want
something pushing a branch
without be explicitly giving permission for that to happen.
Bruce
>
> [YOCTO #9408]
>
> Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
> ---
> scripts/create-pull-request | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/create-pull-request b/scripts/create-pull-request
> index 479ad6e..7dc9836 100755
> --- a/scripts/create-pull-request
> +++ b/scripts/create-pull-request
> @@ -173,8 +173,8 @@ esac
> if [ -n "$WEB_URL" ]; then
> wget --no-check-certificate -q $WEB_URL -O /dev/null
> if [ $? -ne 0 ]; then
> - echo "WARNING: Branch '$BRANCH' was not found on the
> contrib git tree."
> - echo " Please check your remote and branch
> parameter before sending."
> + echo "Branch '$BRANCH' not found on '$REMOTE', creating
> it..."
> + git push $REMOTE $L_BRANCH:$BRANCH
> echo ""
> fi
> fi
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
--
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160418/5615ebd8/attachment-0002.html>
More information about the Openembedded-core
mailing list