[OE-core] [PATCH] perf: pass DESTDIR in EXTRA_OEMAKE

[Bruce Ashfield]

On Tue, Apr 19, 2016 at 8:57 AM, Ross Burton <ross.burton at intel.com> wrote:

> Instead of passing DESTDIR just in the make install invocation, pass it in
> EXTRA_OEMAKE.  This appears to stop perf from rebuilding at instal time
> for me,
> which appears to be the trigger for the random build failure.
>

This also passed my local build tests, but then again, in two weeks of
trying (off and
on), I've never reproduced the race condition .. so I can't comment if it
actually fixes
it or not.

Having a the destdir be consistent for all phases makes sense though, so I
see no
problem with the change as-is.

I'll suspend my nasty perf Makefile hacks to serialize parts of the build
to see if this
holds as a permanent fix for the problem.

Tested-by: Bruce Ashfield <bruce.ashfield at windriver.com>

Bruce


>
> [ YOCTO #9182 ]
>
> Signed-off-by: Ross Burton <ross.burton at intel.com>
> ---
>  meta/recipes-kernel/perf/perf.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/
> perf.bb
> index c43f39c..3d6ffb3 100644
> --- a/meta/recipes-kernel/perf/perf.bb
> +++ b/meta/recipes-kernel/perf/perf.bb
> @@ -88,6 +88,7 @@ EXTRA_OEMAKE = '\
>  '
>
>  EXTRA_OEMAKE += "\
> +    'DESTDIR=${D}' \
>      'prefix=${prefix}' \
>      'bindir=${bindir}' \
>      'sharedir=${datadir}' \
> @@ -110,7 +111,7 @@ do_compile() {
>  do_install() {
>         # Linux kernel build system is expected to do the right thing
>         unset CFLAGS
> -       oe_runmake DESTDIR=${D} install
> +       oe_runmake install
>         # we are checking for this make target to be compatible with older
> perf versions
>         if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" ]
> && grep -q install-python_ext ${S}/tools/perf/Makefile*; then
>                 oe_runmake DESTDIR=${D} install-python_ext
> --
> 2.8.0.rc3
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160419/fa955e38/attachment-0002.html>