[OE-core] [PATCH 2/2] utils.bbclass: warn for deprecated base_contains

Robert Yang liezhi.yang at windriver.com
Fri Apr 22 14:34:15 UTC 2016



On 04/22/2016 07:15 PM, Burton, Ross wrote:
>
> On 22 April 2016 at 06:44, Robert Yang <liezhi.yang at windriver.com
> <mailto:liezhi.yang at windriver.com>> wrote:
>
>     +    bb.warn('base_contains is depracated, please use bb.utils.contains
>     instead.')
>
>
> WARN seems a bit excessive.  Would a NOTE be visible in the output?

Yes, it is visible since it is happened in parsing.

>
> Also typo, "deprecated".

Sorry, updated in the repo:
* warn -> note
* depracated -> deprecated

   git://git.openembedded.org/openembedded-core-contrib rbt/warn
   http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/warn

Robert Yang (2):
   directfb/pango/webkit: base_contains -> bb.utils.contains
   utils.bbclass: warn for deprecated base_contains


Author: Robert Yang <liezhi.yang at windriver.com>
Date:   Thu Apr 21 20:21:22 2016 -0700

     utils.bbclass: note for deprecated base_contains

     Signed-off-by: Robert Yang <liezhi.yang at windriver.com>

diff --git a/meta/classes/utils.bbclass b/meta/classes/utils.bbclass
index 81b92cb..ce639b2 100644
--- a/meta/classes/utils.bbclass
+++ b/meta/classes/utils.bbclass
@@ -24,6 +24,7 @@ def base_version_less_or_equal(variable, checkvalue, 
truevalue, falsevalue, d):
      return oe.utils.version_less_or_equal(variable, checkvalue, truevalue, 
falsevalue, d)

  def base_contains(variable, checkvalues, truevalue, falsevalue, d):
+    bb.note('base_contains is deprecated, please use bb.utils.contains instead.')
      return bb.utils.contains(variable, checkvalues, truevalue, falsevalue, d)

  def base_both_contain(variable1, variable2, checkvalue, d):

// Robert

>
> Ross



More information about the Openembedded-core mailing list