[OE-core] [PATCH 2/6] insane.bbclass: package_qa_check_license -> do_qa_populate_lic
Richard Purdie
richard.purdie at linuxfoundation.org
Tue Apr 26 08:56:03 UTC 2016
On Mon, 2016-04-25 at 06:51 -0700, Robert Yang wrote:
> The package_qa_check_license() was in do_qa_configure which had a
> potential problem, when the recipe sets do_configure[noexec] = "1",
> then
> the license checking won't run, which may hidden license issues.
> Rename
> it to do_qa_populate_lic() and run in do_populate_lic[postfuncs]
> which
> is more reasonable (when no populate license, no license checking).
>
> Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
> ---
> meta/classes/insane.bbclass | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
There is a convention that "do_" as a function prefix means its a task.
In this case its not a task but a function, so can you use a different
prefix please?
Cheers,
Richard
More information about the Openembedded-core
mailing list