[OE-core] [PATCH 1/1] image.bbclass: don't expand IMAGE_CMD when setting do_image task

[Matt Madison]

On Wed, Apr 27, 2016 at 7:39 AM, Burton, Ross <ross.burton at intel.com> wrote:
>
> On 27 April 2016 at 15:19, Matt Madison <matt at madison.systems> wrote:
>>
>> There are other variables that can cause this, too - ${DATE} and
>> ${TIME} by themselves, for example, which aren't deleted.
>
>
> If DATE and TIME were removed would the variables you're using stop
> changing?

That would fix some of the issues, but not all of them.  The latest
case I ran into was in building an sdcard image (from
image_types_fsl.bbclass in meta-fsl-arm).  The first command in
IMAGE_CMD_sdcard is:

   if [ -z "${SDCARD_ROOTFS}" ]; then

SDCARD_ROOTFS is defined using ${IMAGE_NAME}, which in turn includes
${DATETIME}.  When I look at the bitbake-dumpsig output for the
do_image_sdcard task, the value of SDCARD_ROOTFS appears between the
quotation marks, rather than the variable reference in the value of
do_image_sdcard.

I've worked around it by moving the check to another function and
changing IMAGE_CMD_sdcard to call that function to do the test.

Thanks,
-Matt

>
> Ross