[OE-core] [PATCH 1/1] metadata_scm.bbclass: Do not assume ${COREBASE} is a Git repo

[Christopher Larson]

On Tue, Apr 26, 2016 at 12:49 PM, Peter Kjellerstedt <
peter.kjellerstedt at axis.com> wrote:

> The functions base_detect_revision() and base_detect_branch() try to
> extract SCM meta information from the path returned by
> base_get_scmbasepath(), which currently returns ${COREBASE}. However,
> making the assumption that ${COREBASE} contains SCM meta information
> can be false. It is true for Poky, but not necessarily other
> environments. A better option is to look for the SCM meta information
> based on the meta layer.
>
> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt at axis.com>
> ---
>  meta/classes/metadata_scm.bbclass | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/meta/classes/metadata_scm.bbclass
> b/meta/classes/metadata_scm.bbclass
> index 0f7f423..2e6fac2 100644
> --- a/meta/classes/metadata_scm.bbclass
> +++ b/meta/classes/metadata_scm.bbclass
> @@ -4,8 +4,7 @@ METADATA_REVISION ?= "${@base_detect_revision(d)}"
>  def base_detect_revision(d):
>      path = base_get_scmbasepath(d)
>
> -    scms = [base_get_metadata_git_revision, \
> -            base_get_metadata_svn_revision]
> +    scms = [base_get_metadata_git_revision]
>

Was this change intended? Because it doesn't match up with the commit
message, as far as I can see.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160427/5a647fc1/attachment-0002.html>