[OE-core] [PATCH 1/1] metadata_scm.bbclass: Do not assume ${COREBASE} is a Git repo

[Christopher Larson]

On Thu, Apr 28, 2016 at 7:34 AM, Peter Kjellerstedt <
peter.kjellerstedt at axis.com> wrote:

> Yes, it was intentional. I mentioned this in the cover letter. I can of
> course add something about it to the commit message as well if you like.
>

That's what a commit message is for, yes, to describe why something is
being changed. The cover letter isn't going to end up in the git history.
If it hasn't yet been merged, I think it'd be nice to get it improved, so
someone looking at the logs later understands the intention. Thanks.


>
> -    scms = [base_get_metadata_git_revision, \
> -            base_get_metadata_svn_revision]
> +    scms = [base_get_metadata_git_revision]
>
>
>
> Was this change intended? Because it doesn't match up with the commit
> message, as far as I can see.
>
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160428/59143c70/attachment-0002.html>