[OE-core] [PATCH 0/2] meta/classes: correct subprocess.Popen.communicate() return values

Vladimir Zapolskiy vz at mleia.com
Sat Aug 6 01:43:27 UTC 2016


This is a non-functional change, which intends to correct element
names of a tuple returned by Popen.communicate() in oe-core classes
chrpath and package.

Both in python2 and python3 subprocess.Popen.communicate() method
returns a tuple (stdoutdata, stderrdata), thus some old assignments
and collateral comments are incorrect from human's point of view,
however formally there is no error in the code.

The issue was occasionally found by code inspection while investigating
early build errors due to not installed chrpath utility on a host.

The change is desired to have to avoid excessive astonishment while
reading code and of course copy-paste errors in future.

Vladimir Zapolskiy (2):
  chrpath: correct subprocess.Popen.communicate() return values
  package: correct subprocess.Popen.communicate() return values

 meta/classes/chrpath.bbclass | 18 +++++++++---------
 meta/classes/package.bbclass | 12 ++++++------
 2 files changed, 15 insertions(+), 15 deletions(-)

-- 
2.8.1



More information about the Openembedded-core mailing list