[OE-core] [PATCH] piglit: fix build failure with gold linker

[Martin Jansa]

On Mon, Aug 01, 2016 at 06:34:49PM +0300, Maxin B. John wrote:
> When we use gold linker while DISTRO set to "nodistro", piglit build
> fails with the following error:
> 
> | ../../../../lib/libpiglitutil_gl.so.0: error: undefined reference to
> 'dlsym'
> | ../../../../lib/libpiglitutil_gl.so.0: error: undefined reference to
> 'dlerror'
> | ../../../../lib/libpiglitutil_gl.so.0: error: undefined reference to
> 'dlopen'
> | collect2: error: ld returned 1 exit status
> 
> Fix it by providing '-ldl' to LDFLAGS.
> 
> [YOCTO #9851]
> 
> Signed-off-by: Maxin B. John <maxin.john at intel.com>
> ---
>  meta/recipes-graphics/piglit/piglit_git.bb | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/recipes-graphics/piglit/piglit_git.bb b/meta/recipes-graphics/piglit/piglit_git.bb
> index 811f7af..df90c4d 100644
> --- a/meta/recipes-graphics/piglit/piglit_git.bb
> +++ b/meta/recipes-graphics/piglit/piglit_git.bb
> @@ -30,6 +30,8 @@ do_compile[dirs] =+ "${B}/temp/"
>  PACKAGECONFIG ??= ""
>  PACKAGECONFIG[freeglut] = "-DPIGLIT_USE_GLUT=1,-DPIGLIT_USE_GLUT=0,freeglut,"
>  
> +LDFLAGS_append = " ${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', '-ldl', '', d)}"

Shouldn't this be fixed in piglit itself?

And does it need to be applied only for gold?

>  do_configure_prepend() {
>     if [ "${@bb.utils.contains('PACKAGECONFIG', 'freeglut', 'yes', 'no', d)}" = "no" ]; then
>          sed -i -e "/^#.*include <GL\/freeglut_ext.h>$/d" ${S}/src/piglit/glut_wrap.h
> -- 
> 2.4.0
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160802/2fe987e8/attachment-0002.sig>