[OE-core] [PATCH 0/2] package.bbclass: better handling of directory symlinks

Markus Lehtonen markus.lehtonen at linux.intel.com
Thu Aug 4 09:02:10 UTC 2016


FILES specifications that list files under directory symlinks can be
problematic in packaging. Packaging fails if you specify a file within a
symlinked directory but the real target directory is not included. The behavior
on files like this is currently non-deterministic, even for valid
configurations. Packaging may succeed or fail, depending on the order that
files are specified in FILES. This patchset addresses the situation.

The first patch checks FILES for specs that point to files that reside under
symlinked directories. It then handles these separately, failing gracefully if
packaging is not possible (because the real target directory is not included in
the pkg). The second patch simply adds a warning if it finds FILE
specifications that point to files undert symlinked directories.

Basically, these problematic FILE specifications should not be used at all -
files should be specified by their real path. It would probably be best to just
fail if such constructs are found. However, making such a change might have
unwanted consecuences by breaking existing builds. The first patch is not
particularly beautiful but it should make handling of symlinks deterministic
without breaking anything. Printing a warning hopefully courages to fix
potentially problematic recipes. At some point in the future the first patch
could be essentially reverted and the warning turned into an error.

[YOCTO #9827]

The following changes since commit 986f7fbe37a48d050611f08f7160ed96755ac3dc:

  foomatic-filters: Security fixes CVE-2015-8327 (2016-08-01 12:11:09 +0100)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib marquiz/fixes-9827
  http://git.openembedded.org/openembedded-core-contrib/log/?h=marquiz/fixes-9827


Markus Lehtonen (2):
  package.bbclass: better handling of middle-path dir symlinks
  package.bbclass: warn about files under symlinked directories

 meta/classes/package.bbclass | 33 +++++++++++++++++++++++++++++----
 1 file changed, 29 insertions(+), 4 deletions(-)

-- 
2.6.6




More information about the Openembedded-core mailing list