[OE-core] [oe-commits] [openembedded-core] 01/51: piglit: fix build failure with gold linker

[Martin Jansa]

On Wed, Aug 10, 2016 at 09:47:26AM +0000, git at git.openembedded.org wrote:
> rpurdie pushed a commit to branch master
> in repository openembedded-core.
> 
> commit 79005ff905f8c82a8766af5a927b9a0f8929e24f
> Author: Maxin B. John <maxin.john at intel.com>
> AuthorDate: Mon Aug 1 18:34:49 2016 +0300
> 
>     piglit: fix build failure with gold linker
>     
>     When we use gold linker while DISTRO set to "nodistro", piglit build
>     fails with the following error:
>     
>     | ../../../../lib/libpiglitutil_gl.so.0: error: undefined reference to
>     'dlsym'
>     | ../../../../lib/libpiglitutil_gl.so.0: error: undefined reference to
>     'dlerror'
>     | ../../../../lib/libpiglitutil_gl.so.0: error: undefined reference to
>     'dlopen'
>     | collect2: error: ld returned 1 exit status
>     
>     Fix it by providing '-ldl' to LDFLAGS.
>     
>     [YOCTO #9851]
>     
>     Signed-off-by: Maxin B. John <maxin.john at intel.com>
>     Signed-off-by: Ross Burton <ross.burton at intel.com>
> ---
>  meta/recipes-graphics/piglit/piglit_git.bb | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/recipes-graphics/piglit/piglit_git.bb b/meta/recipes-graphics/piglit/piglit_git.bb
> index 811f7af..df90c4d 100644
> --- a/meta/recipes-graphics/piglit/piglit_git.bb
> +++ b/meta/recipes-graphics/piglit/piglit_git.bb
> @@ -30,6 +30,8 @@ do_compile[dirs] =+ "${B}/temp/"
>  PACKAGECONFIG ??= ""
>  PACKAGECONFIG[freeglut] = "-DPIGLIT_USE_GLUT=1,-DPIGLIT_USE_GLUT=0,freeglut,"
>  
> +LDFLAGS_append = " ${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', '-ldl', '', d)}"

There was request to fix it properly in piglit code, why was this
version merged instead?

> +
>  do_configure_prepend() {
>     if [ "${@bb.utils.contains('PACKAGECONFIG', 'freeglut', 'yes', 'no', d)}" = "no" ]; then
>          sed -i -e "/^#.*include <GL\/freeglut_ext.h>$/d" ${S}/src/piglit/glut_wrap.h
> 
> -- 
> To stop receiving notification emails like this one, please contact
> the administrator of this repository.
> -- 
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-commits

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160810/3d627129/attachment-0002.sig>