[OE-core] [meta-oe][PATCH] pcsc-lite: Seperate GPLV3 portions from BSD

[Mark Hatle]

On 8/10/16 2:12 PM, Davis, Michael wrote:
> GPLV3 and BSD portions were originally placed in the same package.
> The GPLv3 portion has been seperated into pcsc-lite-spy so the package can be used with GPLv3 blacklisted.
> 
> Signed-off-by: Michael Davis <michael.davis at essvote.com>
> ---
>  meta-oe/recipes-support/pcsc-lite/pcsc-lite_1.8.13.bb | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/meta-oe/recipes-support/pcsc-lite/pcsc-lite_1.8.13.bb b/meta-oe/recipes-support/pcsc-lite/pcsc-lite_1.8.13.bb
> index cc72549..e1d405b 100644
> --- a/meta-oe/recipes-support/pcsc-lite/pcsc-lite_1.8.13.bb
> +++ b/meta-oe/recipes-support/pcsc-lite/pcsc-lite_1.8.13.bb
> @@ -1,6 +1,7 @@
>  SUMMARY = "PC/SC Lite smart card framework and applications"
>  HOMEPAGE = "http://pcsclite.alioth.debian.org/"
> -LICENSE = "BSD & GPLv3+"
> +LICENSE = "BSD" 

LICENSE should be the overall license(s) of the sources used to produce the
binaries.

So in this case you'd want to do:

LICENSE = "BSD & GPLv3+"
LICENSE_${PN} = "BSD"
LICENSE_${PN}-lib = "BSD"
...
LICENSE_${PN}-spy = "GPLv3+"
LICENSE_${PN}-dev = "GPLv3+"

Once the packages deviate from the overall source code license you need to
explicitly list them for each package.  (The -dbg usually always matches the
${PN}, so that isn't necessary.)

In order to allow for the blacklisting, you may have to add some additional code
to disable the GPL3 pieces if the blacklist is in place.  I think there are some
examples of this elsewhere in oe-core.

--Mark

> +LICENSE_${PN}-spy = "GPLv3+"
>  LICENSE_${PN}-dev = "GPLv3+"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=bcfbd85230ac3c586fb294c8b627cf32"
>  DEPENDS = "udev"
> @@ -20,14 +21,16 @@ EXTRA_OECONF = " \
>  
>  S = "${WORKDIR}/pcsc-lite-${PV}"
>  
> -PACKAGES =+ "${PN}-lib"
> +PACKAGES =+ "${PN}-lib ${PN}-spy"
>  
>  RRECOMMENDS_${PN} = "ccid"
>  
> -FILES_${PN}-lib = "${libdir}/lib*${SOLIBS}"
> +FILES_${PN}-spy += "${bindir}/pcsc-spy \
> +                    ${libdir}/libpcscspy*${SOLIBS}"
> +FILES_${PN}-lib = "${libdir}/libpcsclite*${SOLIBS}"
>  
>  RPROVIDES_${PN} += "${PN}-systemd"
>  RREPLACES_${PN} += "${PN}-systemd"
>  RCONFLICTS_${PN} += "${PN}-systemd"
>  SYSTEMD_SERVICE_${PN} = "pcscd.socket"
> -RDEPENDS_${PN} +="python"
> +RDEPENDS_${PN}-spy +="python"
>