[OE-core] [PATCH 9/9] oeqa.buildperf: be more verbose about failed commands
Markus Lehtonen
markus.lehtonen at linux.intel.com
Fri Aug 12 09:11:26 UTC 2016
Log failures of commands whose output is stored.
Signed-off-by: Markus Lehtonen <markus.lehtonen at linux.intel.com>
---
meta/lib/oeqa/buildperf/base.py | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/meta/lib/oeqa/buildperf/base.py b/meta/lib/oeqa/buildperf/base.py
index 7ea3183..af169e1 100644
--- a/meta/lib/oeqa/buildperf/base.py
+++ b/meta/lib/oeqa/buildperf/base.py
@@ -23,7 +23,7 @@ import unittest
from datetime import datetime, timedelta
from functools import partial
-from oeqa.utils.commands import runCmd, get_bb_vars
+from oeqa.utils.commands import CommandError, runCmd, get_bb_vars
from oeqa.utils.git import GitError, GitRepo
# Get logger for this module
@@ -216,9 +216,15 @@ class BuildPerfTestCase(unittest.TestCase):
def log_cmd_output(self, cmd):
"""Run a command and log it's output"""
+ cmd_str = cmd if isinstance(cmd, str) else ' '.join(cmd)
+ log.info("Logging command: %s", cmd_str)
cmd_log = os.path.join(self.out_dir, 'commands.log')
- with open(cmd_log, 'a') as fobj:
- runCmd2(cmd, stdout=fobj)
+ try:
+ with open(cmd_log, 'a') as fobj:
+ runCmd2(cmd, stdout=fobj)
+ except CommandError as err:
+ log.error("Command failed: %s", err.retcode)
+ raise
def measure_cmd_resources(self, cmd, name, legend):
"""Measure system resource usage of a command"""
--
2.6.6
More information about the Openembedded-core
mailing list