[OE-core] [PATCH 4/4] gettext_0.16.1: whitespace changes to align with v0.19.8.1
Robert P. J. Day
rpjday at crashcourse.ca
Thu Aug 18 16:21:19 UTC 2016
On Thu, 18 Aug 2016, André Draszik wrote:
> +LDFLAGS_prepend_libc-uclibc = " -lrt -lpthread "
i'm not a big fan of doing the above; that is, adding *both* leading
and trailing space to a string, just to play it safe. i know it
doesn't hurt, but it's sloppy and might actually conceal incorrect
string values elsewhere.
if you're "_append"ing, then the string should have only a leading
space; if you're "_prepend"ing, then only a trailing space. the reason
for that is that, if you're rigorous like that, you might actually
catch a string that *doesn't* have the appropriate spaces, but is
getting away with it only because a string elsewhere is being generous
and covering for it.
and, yes, i *am* that pedantic.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
More information about the Openembedded-core
mailing list