[OE-core] [PATCH] image_types: use COMPRESSIONTYPES variable for backward compatibility

Ylinen, Mikko mikko.ylinen at intel.com
Fri Aug 19 18:37:46 UTC 2016


Hi,

On Fri, Aug 19, 2016 at 5:45 PM, Richard Purdie <
richard.purdie at linuxfoundation.org> wrote:

> On Fri, 2016-08-19 at 17:35 +0300, Ed Bartosh wrote:
> > Recent renaming of COMPRESSIONTYPES variable can break recipes that
> > still use it. Including value of COMPRESSIONTYPES variable into
> > CONVERSIONTYPES should prevent this.
> >
> > Signed-off-by: Ed Bartosh <ed.bartosh at linux.intel.com>
> > ---
> >  meta/classes/image_types.bbclass | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
>
> Does this actually work? Won't COMPRESSION_CMD be unset in these cases
> so it would just trigger further failures?
>
> Perhaps we should just error and tell the user if COMPRESSION_TYPES is
> set (in sanity.bbclass?).
>

These lines were simply missing
from 9d68c024790850cab72ead1e3372a5fcec4ef7b0
(the commit message talks about these lines).

In Ostro we add a few custom conversions via COMPRESSIONTYPES_append and
without
this patch those types are not recognized and we hit:

"No IMAGE_CMD defined for IMAGE_FSTYPES entry 'dsk.ova' - possibly invalid
type name or missing support class"

(ova is one of our COMPRESSIONTYPES).

-- Mikko
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160819/ed6a3789/attachment-0002.html>


More information about the Openembedded-core mailing list