[OE-core] [PATCH V1] unzip: fixes strange output

[Jussi Kukkonen]

On 30 August 2016 at 10:21, Jussi Kukkonen <jussi.kukkonen at intel.com> wrote:

> On 30 August 2016 at 05:17, Edwin Plauchu <edwin.plauchu.camacho at linux.
> intel.com> wrote:
> >
> > From: Edwin Plauchu <edwin.plauchu.camacho at intel.com>
> >
> > This fixes commit 763a3d424bccf559a8d6add3dc1f2746c82f2933
> >
> > Output was strange when using unzip to extract zip file.
> > This patch fixed so.
> >
> > [YOCTO #9551]
> >
> > Signed-off-by: Edwin Plauchu <edwin.plauchu.camacho at intel.com>
> > ---
> >  .../unzip/unzip/fix-security-format.patch          | 198
> ++++++++-------------
> >  1 file changed, 78 insertions(+), 120 deletions(-)
> >
> > diff --git a/meta/recipes-extended/unzip/unzip/fix-security-format.patch
> b/meta/recipes-extended/unzip/unzip/fix-security-format.patch
> > index c82f502..8e9b06c 100644
> > --- a/meta/recipes-extended/unzip/unzip/fix-security-format.patch
> > +++ b/meta/recipes-extended/unzip/unzip/fix-security-format.patch
> > @@ -9,131 +9,89 @@ Upstream-Status: Pending
> >
> >  Signed-off-by: Edwin Plauchu <edwin.plauchu.camacho at intel.com>
> >
> > -diff --git a/unzpriv.h b/unzpriv.h
> > -index c8d3eab..85e693a 100644
> > ---- a/unzpriv.h
> > -+++ b/unzpriv.h
> > -@@ -1006,7 +1006,7 @@
> > - #    define LoadFarStringSmall(x)   Qstrfix(x)
> > - #    define LoadFarStringSmall2(x)  Qstrfix(x)
> > - #  else
> > --#    define LoadFarString(x)        (char *)(x)
> > -+#    define LoadFarString(x)        "%s",(char *)(x)
>
> LoadFarString is used a _lot_ in various different ways, usually as
> argument to another macro or function. This sort of macro change seems
> potentially very dangerous in C, have you checked this is ok in every case?.
>

Edwin just pointed out to me that the patch actually removes this macro
change, and he's correct. My patch-of-patch reading failure.

So I'm fine with this patch, sorry for noise.
  Jussi
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160830/664081a4/attachment-0002.html>