[OE-core] [PATCH 3/4] initscripts: support persistent /var/log

[ChenQi]

On 12/12/2016 04:05 PM, Patrick Ohly wrote:
> On Tue, 2016-11-22 at 18:10 +0800, Chen Qi wrote:
>> ${WORKDIR}/volatiles         ${D}${sysconfdir}/default/volatiles/00_core
>> +       if [ "${VOLATILE_LOG_DIR}" = "log" ]; then
>> +               echo "l root root 0755 /var/log /var/volatile/log" >>
>> ${D}${sysconfdir}/default/volatiles/00_core
>> +       fi
> Why are you checking for "log" here? I thought VOLATILE_LOG_DIR was
> supposed to be a boolean?
>
> Using oe.types.boolean in shell code is a bit awkward, but would be
> necessary for the sake of consistency when allowing VOLATILE_LOG_DIR to
> have more than just yes/no. Untested (relies on bool->str conversion):
>
> if [ ${@ oe.types.boolean('${VOLATILE_LOG_DIR}') } = True ]; then
>

Thanks for your suggestion.

I'll send out V2.

Best Regards,

Chen Qi