[OE-core] [PATCH v2 27/28] classes/testimage: exportTests simple improvment to use list instead of test expresions.

[Aníbal Limón]

Ok agreed.

On 02/04/2016 12:34 PM, Paul Eggleton wrote:
> On Tue, 02 Feb 2016 18:30:39 Aníbal Limón wrote:
>> It's better to use a list instead if variable isn't match some value.
>>
>> Signed-off-by: Aníbal Limón <anibal.limon at linux.intel.com>
>> ---
>>  meta/classes/testimage.bbclass | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/testimage.bbclass b/meta/classes/testimage.bbclass
>> index 57858e6..7fff29f 100644
>> --- a/meta/classes/testimage.bbclass
>> +++ b/meta/classes/testimage.bbclass
>> @@ -112,7 +112,7 @@ def exportTests(d,tc):
>>      savedata["host_dumper"] = {}
>>      for key in tc.__dict__:
>>          # special cases
>> -        if key != "d" and key != "target" and key != "host_dumper" and key
>> != "suite": +        if key not in ['d', 'target', 'host_dumper', 'suite']:
>>              savedata[key] = getattr(tc, key)
>>      savedata["target"]["ip"] = tc.target.ip or d.getVar("TEST_TARGET_IP",
>> True) savedata["target"]["server_ip"] = tc.target.server_ip or
>> d.getVar("TEST_SERVER_IP", True)
> 
> Please squash this into the commit where you're adding the "suite" item.
> 
> Cheers,
> Paul
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160204/5a036f3f/attachment-0002.sig>