[OE-core] [PATCH 1/6] systemd: move bash completion into separate package

[Maciek Borzecki]

On pon, 2016-02-08 at 12:20 +0200, Tanu Kaskinen wrote:
> On Mon, 2016-02-08 at 11:09 +0100, Maciej Borzecki wrote:
> > Add systemd-bash package that ships bash completion files
> > 
> > Signed-off-by: Maciej Borzecki <maciej.borzecki at open-rnd.pl>
> > ---
> >  meta/recipes-core/systemd/systemd_228.bb | 9 ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> > 
> > diff --git a/meta/recipes-core/systemd/systemd_228.bb b/meta/recipes-
> > core/systemd/systemd_228.bb
> > index
> > a110f0cdeaac7e46b5691a89aea237974e4114b3..8e3cb6047588b286df728ff28423e469d0b0745d
> > 100644
> > --- a/meta/recipes-core/systemd/systemd_228.bb
> > +++ b/meta/recipes-core/systemd/systemd_228.bb
> > @@ -238,7 +238,7 @@ python populate_packages_prepend (){
> >  PACKAGES_DYNAMIC += "^lib(udev|systemd).*"
> >  
> >  PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs ${PN}-analyze ${PN}-
> > kernel-install \
> > -             ${PN}-rpm-macros ${PN}-binfmt ${PN}-pam ${PN}-zsh ${PN}-xorg-xinitrc"
> > +             ${PN}-rpm-macros ${PN}-binfmt ${PN}-pam ${PN}-bash ${PN}-zsh ${PN}-xorg-
> > xinitrc"
> >  
> >  SYSTEMD_PACKAGES = "${PN}-binfmt"
> >  SYSTEMD_SERVICE_${PN}-binfmt = "systemd-binfmt.service"
> > @@ -271,6 +271,11 @@ FILES_${PN}-rpm-macros = "${exec_prefix}/lib/rpm \
> >  
> >  FILES_${PN}-xorg-xinitrc = "${sysconfdir}/X11/xinit/xinitrc.d/*"
> >  
> > +FILES_${PN}-bash = " \
> > +                    ${datadir}/bash-completion \
> > +                    ${sysconfdir}/bash_completion.d/ \
> > +                    "
> 
> Note that we have the bash-completion class. It can be used to take
> care of packaging the bash completion files. It doesn't take files from
> sysconfdir, though. Does systemd really install bash completion files
> under sysconfdir, or is that just unnecessary cruft originating from
> older systemd versions?
> 

Thanks for the tip. Now that I've looked at it inherit bash-completion looks like the most
sensible way. I guess it also makes sense to have an equivalent zsh completion class.

-- 
Maciej Borzęcki
Senior Software Developer at Open-RnD Sp. z o.o., Poland
www.open-rnd.pl
mobile: +48 889 117 365, fax: +48 42 657 9079

Niniejsza wiadomość wraz z załącznikami może zawierać chronione prawem
lub poufne informacje i została wysłana wyłącznie do wiadomości i
użytku osób, do których została zaadresowana. Jeśli wiadomość została
otrzymana przypadkowo zabrania się jej kopiowania lub rozsyłania do
osób trzecich. W takim przypadku uprasza się o natychmiastowe
zniszczenie wiadomości oraz poinformowanie nadawcy o zaistniałej
sytuacji za pomocą wiadomości zwrotnej. Dziękujemy.

This message, including any attachments hereto, may contain privileged
or confidential information and is sent solely for the attention and
use of the intended addressee(s). If you are not an intended addressee,
you may neither use this message nor copy or deliver it to anyone. In
such case, you should immediately destroy this message and kindly notify
the sender by reply email. Thank you.