[OE-core] [PATCH 2/3] oe/gpg_sign: check for python-pexpect when using local signing

Ioan-Adrian Ratiu adrian.ratiu at ni.com
Mon Feb 8 11:17:49 UTC 2016


Hello

On Mon, 8 Feb 2016 12:52:39 +0200
Markus Lehtonen <markus.lehtonen at linux.intel.com> wrote:

> On Fri, 2016-02-05 at 14:31 +0000, Burton, Ross wrote:
> > 
> > On 5 February 2016 at 14:00, Markus Lehtonen <
> > markus.lehtonen at linux.intel.com> wrote:
> > > +            msgs.append("Please install python-pexpect that is
> > > needed by lcocal gpg signing.")
> > > 
> > Isn't this only needed if signing RPMs?  Hopefully in the future this
> > class will be used for more than RPM signing and detached signing
> > doesn't need pexpect.
> Yes, that is true. Any suggestions how to change this? Just try
> ImportError in sign_rpms() and fail there(?)

I'm using "from subprocess import Popen" for ipk signing. Isn't it by default included as opposed to python-pexpect?
We could use that.

I'll try to update today or tomorrow the patches for ipk signing to use the gpg backend and I'll resubmit them.

> > Also, typo in "local".
> Typo fixed (and commit message modified) in my contrib repo:
> git://git.openembedded.org/openembedded-core-contrib marquiz/rpmsign
> 
> 
> Thanks,
>   Markus




More information about the Openembedded-core mailing list