[OE-core] [PATCH 2/2] gdb: drop unnecessary CC_FOR_BUILD etc exports

[Andre McCurdy]

On Mon, Feb 8, 2016 at 11:48 AM, Khem Raj <raj.khem at gmail.com> wrote:
> On Mon, Feb 8, 2016 at 11:35 AM, Andre McCurdy <armccurdy at gmail.com> wrote:
>> These exports are all provided by autotool.bbclass
>>
>>   http://git.openembedded.org/openembedded-core/commit/?id=edf30561184ec42e5692a55fdf93304fac0fdb1b
>>
>> Signed-off-by: Andre McCurdy <armccurdy at gmail.com>
>> ---
>>  meta/recipes-devtools/gdb/gdb-common.inc | 7 +------
>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc
>> index 6baeb0b..06272a9 100644
>> --- a/meta/recipes-devtools/gdb/gdb-common.inc
>> +++ b/meta/recipes-devtools/gdb/gdb-common.inc
>> @@ -22,16 +22,11 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
>>                 file://COPYING.LIB;md5=9f604d8a4f8e74f4f5140845a21b6674 \
>>                 file://COPYING3;md5=d32239bcb673463ab874e80d47fae504 \
>>                 file://COPYING3.LIB;md5=6a6a8e020838b23406c81b19c1d46df6"
>> +
>>  inherit autotools texinfo
>>
>>  SRC_URI = "${GNU_MIRROR}/gdb/gdb-${PV}.tar.gz \
>>            "
>> -export CC_FOR_BUILD = "${BUILD_CC}"
>> -export CXX_FOR_BUILD = "${BUILD_CXX}"
>> -export CPP_FOR_BUILD = "${BUILD_CPP}"
>> -export CFLAGS_FOR_BUILD = "${BUILD_CFLAGS}"
>> -export CXXFLAGS_FOR_BUILD = "${BUILD_CXXFLAGS}"
>> -export CPPFLAGS_FOR_BUILD = "${BUILD_CPPFLAGS}"
>>
>
> you should build all flavours of gdb recipes for one architectures
> including mutlilib combination to test this out.

I checked that these exports all exactly match the ones in
autotools.bbclass so it's not clear what could go wrong.

Is there a combination which you suspect will have trouble with this patch?


>>  B = "${WORKDIR}/build-${TARGET_SYS}"
>>
>> --
>> 1.9.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core