[OE-core] [PATCH 1/2] libproxy: replace PACKAGECONFIG equivalent with the real thing

[Paul Eggleton]

On Tue, 09 Feb 2016 00:05:15 Andre McCurdy wrote:
> On Mon, Feb 8, 2016 at 2:56 PM, Burton, Ross <ross.burton at intel.com> wrote:
> > On 8 February 2016 at 20:34, Andre McCurdy <armccurdy at gmail.com> wrote:
> >> '' if incompatible_license_contains('GPLv3', 'x', '', d) == 'x' or
> >> bb.utils.contains('DISTRO_FEATURES', 'x11', 'x', '', d) == '' else
> >> 'gnome' } \
> > 
> > Instead of returning 'x' or '' and then doing string comparisons, why not
> > just return True or False and let if/or/else do the right thing?
> 
> Just trying to preserve the original logic to make it clearer that no
> functionality is being changed.
> 
> The logic can be traced back to Paul Eggleton's original version here:
>  
> http://git.openembedded.org/openembedded-core/commit/?id=973351cf2e338f07c1
> 1395d494193e9c62857f2d

Well, slap my wrist then ;)

Ross's suggestion does make it a bit tidier.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre