[OE-core] [PATCH 1/9] distutils: Consider S != B case

[Phil Blundell]

On Wed, 2016-02-10 at 17:43 +0000, Khem Raj wrote:
> +        cwd=$PWD;cd ${S}
> +        STAGING_INCDIR=${STAGING_INCDIR} \
> +        STAGING_LIBDIR=${STAGING_LIBDIR} \
> +        BUILD_SYS=${BUILD_SYS} HOST_SYS=${HOST_SYS} \
> +        ${STAGING_BINDIR_NATIVE}/${PYTHON_PN}-native/${PYTHON_PN} ${S}/setup.py build --build-base=${B} ${DISTUTILS_BUILD_ARGS} || \
> +        bbfatal "${PYTHON_PN} setup.py build execution failed."
> +        cd $cwd

Why do you need to save and restore the cwd?  If this is a shell task
then the "cd" would be local to that shell invocation anyway, right?

Also, given that you're invoking it by full pathname as
"${S}/setup.py ..." anyway, do you even need ${S} to be the cwd in the
first place?  That seems a bit redundant.

p.