[OE-core] [PATCH] cml1.bbclass: fix do_menuconfig

[Andrea Adami]

On Thu, Feb 18, 2016 at 7:46 AM, Markus Lehtonen
<markus.lehtonen at linux.intel.com> wrote:
> The functionality got broken after bitbake commit
> 8bf33a8e92c0e188fa392030025756196c96fcbb
> which disabled the (bitbake) variable expansion inside python functions.
>
> Signed-off-by: Markus Lehtonen <markus.lehtonen at linux.intel.com>
> ---
>  meta/classes/cml1.bbclass | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
> index 95cf584..4067dc0 100644
> --- a/meta/classes/cml1.bbclass
> +++ b/meta/classes/cml1.bbclass
> @@ -26,7 +26,8 @@ python do_menuconfig() {
>      except OSError:
>          mtime = 0
>
> -    oe_terminal("${SHELL} -c \"make ${KCONFIG_CONFIG_COMMAND}; if [ \$? -ne 0 ]; then echo 'Command failed.'; printf 'Press any key to continue... '; read r; fi\"", '${PN} Configuration', d)
> +    oe_terminal("${SHELL} -c \"make %s; if [ \$? -ne 0 ]; then echo 'Command failed.'; printf 'Press any key to continue... '; read r; fi\"" % d.getVar('KCONFIG_CONFIG_COMMAND'),
> +                d.getVar('PN', True ) + ' Configuration', d)
>
>      # FIXME this check can be removed when the minimum bitbake version has been bumped
>      if hasattr(bb.build, 'write_taint'):
> --
> 2.6.2
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Hello,

with pull of today build fails with a deceiving log:
Exception: TypeError: getVar() takes at least 3 arguments (2 given)

There seems to be a missing expand parameter in your patch, mandatory
after commit aa3faeb

 -d.getVar('KCONFIG_CONFIG_COMMAND')
+d.getVar('KCONFIG_CONFIG_COMMAND', True)

Regards
Andrea