[OE-core] [PATCH] gcc5: Fix build on NIOS2

[Khem Raj]

On Wed, Jan 6, 2016 at 3:56 AM, Marek Vasut <marex at denx.de> wrote:
> On Wednesday, January 06, 2016 at 03:54:11 AM, Khem Raj wrote:
>> > On Jan 5, 2016, at 6:13 PM, Marek Vasut <marex at denx.de> wrote:
>> >
>> > The gcc 5.3 does not build on NIOS2 due to a missing MUSL_DYNAMIC_LINKER
>> > definition in it's config file. Add the definition to fix the build
>> > issue. The output produced during the failing build is as follows:
>> >
>> > g++    -isystem/b/tmp/sysroots/x86_64-linux/usr/include -O2 -pipe
>> > -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti
>> > -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
>> > -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic
>> > -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings
>> > -DHAVE_CONFIG_H -static-libstdc++ -static-libgcc
>> > -L/b/tmp/sysroots/x86_64-linux/usr/lib
>> > -L/b/tmp/sysroots/x86_64-linux/lib
>> > -Wl,-rpath-link,/b/tmp/sysroots/x86_64-linux/usr/lib
>> > -Wl,-rpath-link,/b/tmp/sysroots/x86_64-linux/lib
>> > -Wl,-rpath,/b/tmp/sysroots/x86_64-linux/usr/lib
>> > -Wl,-rpath,/b/tmp/sysroots/x86_64-linux/lib -Wl,-O1 gcc-ar.o -o gcc-ar \
>> >
>> >        file-find.o libcommon.a ../libcpp/libcpp.a
>> >        ../libbacktrace/.libs/libbacktrace.a ../libiberty/libiberty.a
>> >        ../libdecnumber/libdecnumber.a
>> >
>> > In file included from ./tm.h:27:0,
>> >
>> >                 from /b/tmp/work-shared/gcc-5.3.0-r0/gcc-5.3.0/gcc/gcc.c:34:
>> > ./config/linux.h:92:28: error: expected ',' or ';' before
>> > 'MUSL_DYNAMIC_LINKER'
>> >
>> >     BIONIC_DYNAMIC_LINKER, MUSL_DYNAMIC_LINKER)
>> >
>> >                            ^
>> >
>> > ./config/linux.h:59:60: note: in definition of macro
>> > 'CHOOSE_DYNAMIC_LINKER1'
>> >
>> >   "%{" LIBC2 ":" LD2 ";:%{" LIBC3 ":" LD3 ";:%{" LIBC4 ":" LD4 ";:" LD1
>> >   "}}}"
>> >
>> >                                                            ^
>> >
>> > ./config/linux.h:91:3: note: in expansion of macro
>> > 'CHOOSE_DYNAMIC_LINKER'
>> >
>> >   CHOOSE_DYNAMIC_LINKER (GLIBC_DYNAMIC_LINKER, UCLIBC_DYNAMIC_LINKER, \
>> >   ^
>> >
>> > ./config/nios2/linux.h:40:25: note: in expansion of macro
>> > 'GNU_USER_DYNAMIC_LINKER'
>> >
>> >       -dynamic-linker " GNU_USER_DYNAMIC_LINKER "} \
>> >
>> >                         ^
>> >
>> > /b/tmp/work-shared/gcc-5.3.0-r0/gcc-5.3.0/gcc/gcc.c:884:32: note: in
>> > expansion of macro 'LINK_SPEC' static const char *link_spec = LINK_SPEC;
>> >
>> >                                ^
>> >
>> > <command-line>:0:27: warning: deprecated conversion from string constant
>> > to 'char*' [-Wwrite-strings]
>> > /b/tmp/work-shared/gcc-5.3.0-r0/gcc-5.3.0/gcc/gcc.c:1295:48: note: in
>> > expansion of macro 'STANDARD_STARTFILE_PREFIX' static char *const
>> > standard_startfile_prefix = STANDARD_STARTFILE_PREFIX;
>>
>> This is ok to install.
>
> Hi Khem, I don't quite get your comment, but check the error above. That's
> what this patch addresses, the splat below is just a fallout from it.

it mean patch is ok to install :)

>
> Best regards,
> Marek Vasut