[OE-core] [PATCH 1/2] copy_buildsystem.py: Allow substring matches for excluded_targets
Paul Eggleton
paul.eggleton at linux.intel.com
Wed Jan 6 22:42:48 UTC 2016
Hi Randy,
On Wed, 06 Jan 2016 14:15:49 Randy Witt wrote:
> This is so that the excluded_targets passed to prune_lockedsigs can
> take a partial form such as nativesdk to filter based on partial matches.
>
> Signed-off-by: Randy Witt <randy.e.witt at linux.intel.com>
> ---
> meta/lib/oe/copy_buildsystem.py | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/meta/lib/oe/copy_buildsystem.py
> b/meta/lib/oe/copy_buildsystem.py index 15af4eb..9d8f3a6 100644
> --- a/meta/lib/oe/copy_buildsystem.py
> +++ b/meta/lib/oe/copy_buildsystem.py
> @@ -83,8 +83,11 @@ def prune_lockedsigs(allowed_tasks, excluded_targets,
> lockedsigs, pruned_output) for line in infile:
> if invalue:
> if line.endswith('\\\n'):
> - splitval = line.strip().split(':')
> - if splitval[1] in allowed_tasks and not splitval[0]
> in excluded_targets: + target, task =
> line.strip().split(':')[:2] + badmatch = ([x for x
> in excluded_targets.split() + if x in
> target])
> +
> + if task in allowed_tasks and not badmatch:
Actually Mark and I have just noticed excluded_targets is being treated as a
list in the original code here but we're passing in a string. I think maybe
expecting the caller to supply a list would be a better approach (so we would
call .split() on the value of SDK_TARGETS before passing it in). Could you
take care of that in a separate patch before doing this?
Thanks,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
More information about the Openembedded-core
mailing list