[OE-core] [PATCH 1/2] glibc-initial.inc: use relative path to run configure

[Mark Hatle]

On 1/11/16 8:55 AM, Trevor Woerner wrote:
> 
> 
> On 01/11/16 00:11, Robert Yang wrote:
>> Avoid potential build path in output files.
>>
>> [YOCTO #8894]
>>
>> Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
>> ---
>>  meta/recipes-core/glibc/glibc-initial.inc |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/glibc/glibc-initial.inc b/meta/recipes-core/glibc/glibc-initial.inc
>> index 8e81f09..cb2f8dd 100644
>> --- a/meta/recipes-core/glibc/glibc-initial.inc
>> +++ b/meta/recipes-core/glibc/glibc-initial.inc
>> @@ -11,7 +11,7 @@ TOOLCHAIN_OPTIONS = " --sysroot=${STAGING_DIR_TCBOOTSTRAP}"
>>  do_configure () {
>>  	(cd ${S} && gnu-configize) || die "failure in running gnu-configize"
>>  	find ${S} -name "configure" | xargs touch
>> -	${S}/configure --host=${TARGET_SYS} --build=${BUILD_SYS} \
>> +	../git/configure --host=${TARGET_SYS} --build=${BUILD_SYS} \
> 
> Although I haven't tested it, this _looks_ like it might fail quite
> readily. I'm sure there are some recipes that play tricks with ${S}, and
> what about recipes that don't pull their sources from git?
> 
> Maybe something like: (cd ${S} && ./configure ...) would be better?

That won't work since it'll run configure in the S directory.

IF we need to use relative paths here, we need to calculate the relative path
from B to S and use that.  It looks like patch 2/2 already does something like
this using the python..  we can probably do the same.  (I don't know any reason,
at least for glibc, that all of the items won't be in the same "WORKDIR".  So it
would be relative within the WORKDIR, which SHOULD be fine.)

>>  		--prefix=/usr \
>>  		--without-cvs --disable-sanity-checks \
>>  		--with-headers=${STAGING_DIR_TARGET}${includedir} \
>