[OE-core] [PATCH 2/3] valgrind: don't restrict to armv7a

[Khem Raj]

On Tue, Jan 12, 2016 at 7:23 PM, Andre McCurdy <armccurdy at gmail.com> wrote:
> On Tue, Jan 12, 2016 at 6:18 PM, dengke.du at windriver.com
> <dengke.du at windriver.com> wrote:
>> Hi Alexander
>>
>> I got valgrind do_compile error:
>>
>> MACHINE = "qemuarm"
>> $ bitbake valgrind
>>
>> warning: switch -mcpu=cortex-a8 conflicts with -march=armv5e switch

-mcpu=cortex-a8 used for armv5 may not be right but patches from

https://bugs.kde.org/show_bug.cgi?id=248998

are helpful.


>> | {standard input}:25: Error: selected processor does not support ARM mode
>> `movw r3,#:lower16:primary_map'
>> | {standard input}:28: Error: selected processor does not support ARM mode
>> `movt r3,#:upper16:primary_map'
>> | {standard input}:30: Error: selected processor does not support ARM mode
>> `uxth r1,r0'
>> | {standard input}:31: Error: selected processor does not support ARM mode
>> `movw r3,#0xAAAA'
>> | {standard input}:40: Error: selected processor does not support ARM mode
>> `movw r3,#0x5555'
>> | {standard input}:61: Error: selected processor does not support ARM mode
>> `movw r3,#:lower16:primary_map'
>> | {standard input}:64: Error: selected processor does not support ARM mode
>> `movt r3,#:upper16:primary_map'
>> | {standard input}:66: Error: selected processor does not support ARM mode
>> `uxth r1,r0'
>> | {standard input}:94: Error: selected processor does not support ARM mode
>> `movw r3,#:lower16:primary_map'
>> | {standard input}:95: Error: selected processor does not support ARM mode
>> `uxth r1,r0'
>> | {standard input}:96: Error: selected processor does not support ARM mode
>> `movt r3,#:upper16:primary_map'
>> | {standard input}:135: Error: selected processor does not support ARM mode
>> `movw r3,#:lower16:primary_map'
>> | {standard input}:136: Error: selected processor does not support ARM mode
>> `uxth r1,r0'
>> | {standard input}:137: Error: selected processor does not support ARM mode
>> `movt r3,#:upper16:primary_map'
>
> Apparently Khem had this working prior to the update to valgrind v3.11
>
>   http://lists.openembedded.org/pipermail/openembedded-core/2015-December/114340.html
>
> Looking at the code I don't see any easy way to build for armv5
> though. Maybe it's hackable, but the result probably wouldn't be
> suitable for oe-core.
>
> Probably the best solution is to restore the blacklisting of armv6 and
> below. I'll send a patch.
>
>> Thanks!
>>
>> //dengke
>>
>> On 2016年01月08日 22:57, Alexander Kanavin wrote:
>>
>> From: Andre McCurdy <armccurdy at gmail.com>
>>
>> Valgrind has been tested on armv5te/qemuarm, so it seems
>> that valgrind's configure check for armv7 is over cautious.
>>
>> Signed-off-by: Andre McCurdy <armccurdy at gmail.com>
>> Signed-off-by: Alexander Kanavin <alexander.kanavin at linux.intel.com>
>> ---
>>  meta/recipes-devtools/valgrind/valgrind_3.11.0.bb | 8 +++++---
>>  1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>> b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>> index 0823144..575db35 100644
>> --- a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>> +++ b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
>> @@ -27,14 +27,16 @@ SRC_URI =
>> "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
>>  SRC_URI[md5sum] = "4ea62074da73ae82e0162d6550d3f129"
>>  SRC_URI[sha256sum] =
>> "6c396271a8c1ddd5a6fb9abe714ea1e8a86fce85b30ab26b4266aeb4c2413b42"
>>
>> -COMPATIBLE_HOST = '(i.86|x86_64|mips|powerpc|powerpc64).*-linux'
>> -COMPATIBLE_HOST_armv7a = 'arm.*-linux'
>> +COMPATIBLE_HOST = '(i.86|x86_64|arm|mips|powerpc|powerpc64).*-linux'
>>
>>  inherit autotools ptest
>>
>>  EXTRA_OECONF = "--enable-tls --without-mpicc"
>> -EXTRA_OECONF_armv7a = "--enable-tls -host=armv7-none-linux-gnueabi
>> --without-mpicc"
>>  EXTRA_OECONF +=
>> "${@['--enable-only32bit','--enable-only64bit'][d.getVar('SITEINFO_BITS',
>> True) != '32']}"
>> +
>> +# valgrind checks host_cpu "armv7*)", so we need to over-ride the
>> autotools.bbclass default --host option
>> +EXTRA_OECONF_append_arm = " --host=armv7${HOST_VENDOR}-${HOST_OS}"
>> +
>>  EXTRA_OEMAKE = "-w"
>>
>>  CFLAGS_append_libc-uclibc = " -D__UCLIBC__ "
>>
>>
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core