[OE-core] [PATCH] image: Fix wic environment issues
Richard Purdie
richard.purdie at linuxfoundation.org
Sat Jan 16 10:32:44 UTC 2016
The wic environment function needs to run after the rootfs size is
setup. This fixes:
======================================================================
FAIL: test_image_env (oeqa.selftest.wic.Wic)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/utils/decorators.py", line 106, in wrapped_f
return func(*args, **kwargs)
File "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/selftest/wic.py", line 218, in test_image_env
self.assertTrue(var in content, "%s is not in .env file" % var)
AssertionError: False is not true : ROOTFS_SIZE is not in .env file
Ultimately this code can move to the main wic image task but this
fixes things for now.
Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index cc8a23c..8ff157a 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -242,8 +242,6 @@ fakeroot python do_image () {
pre_process_cmds = d.getVar("IMAGE_PREPROCESS_COMMAND", True)
execute_pre_post_process(d, pre_process_cmds)
-
- write_wic_env(d)
}
do_image[dirs] = "${TOPDIR}"
do_image[umask] = "022"
@@ -264,7 +262,7 @@ addtask do_image_complete after do_image before do_build
# Write environment variables used by wic
# to tmp/sysroots/<machine>/imgdata/<image>.env
#
-def write_wic_env(d):
+python write_wic_env () {
wicvars = d.getVar('WICVARS', True)
if not wicvars:
return
@@ -278,6 +276,7 @@ def write_wic_env(d):
value = d.getVar(var, True)
if value:
envf.write('%s="%s"\n' % (var, value.strip()))
+}
def setup_debugfs_variables(d):
d.appendVar('IMAGE_ROOTFS', '-dbg')
@@ -393,6 +392,9 @@ python () {
d.setVarFlag('do_image_%s' % t, 'subimages', subimages)
d.appendVarFlag('do_image_%s' % t, 'vardeps', ' '.join(vardeps))
+ if realt == "wic":
+ d.appendVarFlag('do_image_%s' % t, 'prefuncs', ' write_wic_env')
+
after = 'do_image'
for dep in typedeps[t]:
after += ' do_image_%s' % dep
More information about the Openembedded-core
mailing list