[OE-core] [PATCH 1/1] linux-libc-headers: set ALLOW_EMPTY

[Martin Jansa]

On Tue, Jan 19, 2016 at 11:12:18AM +0800, Jian Liu wrote:
> 
> 
> On 2016年01月16日 02:17, Richard Purdie wrote:
> > On Thu, 2016-01-14 at 14:46 +0800, Jian Liu wrote:
> >> If setting IMAGE_INSTALL += "linux-libc-headers", do_rootfs will
> >> cause
> >> error.
> >>    ERROR: linux-libc-headers not found in the base feeds
> >>
> >> This is because that there is no linux-libc-headers.rpm generated.
> > There is no point in generating an empty package just for the sake of
> > it. Surely you just shouldn't put that in IMAGE_INSTALL?
> >
> > Cheers,
> >
> > Richard
> 
> Yes, I submit this patch just considering that someone who is not 
> familiar with yocto may be confused
> by this behavior. There is linux-libc-headers bb file so IMAGE_INSTALL 
> += "linux-libc-headers" is taken for
> granted.
> 
> This is really not a bug and it is just a usage problem.

And you're making it worse, by allowing such person to install
completely useless empty package assuming that (s)he installed
linux-libc-headers to the image.

Error message is _much_ better than empty useless package.

> >> diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc
> >> -headers.inc b/meta/recipes-kernel/linux-libc-headers/linux-libc
> >> -headers.inc
> >> index 2ba6ed5..403360b 100644
> >> --- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
> >> +++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
> >> @@ -76,3 +76,5 @@ RRECOMMENDS_${PN}-dbg = "${PN}-dev (=
> >> ${EXTENDPKGV})"
> >>   
> >>   INHIBIT_DEFAULT_DEPS = "1"
> >>   DEPENDS += "unifdef-native"
> >> +
> >> +ALLOW_EMPTY_${PN} = "1"
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160119/aaabd245/attachment-0002.sig>