[OE-core] [PATCH] dpkg-deb: strip virtual/ package prefix in control files

[Richard Purdie]

On Wed, 2016-07-06 at 13:35 -0400, Joe MacDonald wrote:
> [Re: [OE-core] [PATCH] dpkg-deb: strip virtual/ package prefix in
> control files] On 16.07.06 (Wed 17:48) Richard Purdie wrote:
> 
> > On Wed, 2016-07-06 at 09:45 -0400, Joe MacDonald wrote:
> > > If a recipe provides a 'virtual/foo', dpkg-deb will fail as '/'
> > > characters
> > > are not allowed in any of the Depends, Recommends, Suggests, etc.
> > > fields.
> > > The intent of these in the Debian package system and the few
> > > cases
> > > where
> > > they are used in Yocto layers seems like throwing away the
> > > 'virtual/'
> > > prefix preserves the intent, while not requiring it to be removed
> > > for
> > > package systems that allow it (eg. opkg and rpm).
> > > 
> > > Signed-off-by: Joe MacDonald <joe_macdonald at mentor.com>
> > > ---
> > >  meta/classes/package_deb.bbclass | 12 ++++++------
> > >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > Our virtual/ namespace is only used in DEPENDS, not in the runtime
> > package namespaces (RDEPENDS, RRECOMMENDS and friends). We
> > therefore
> > shouldn't need this patch...
> 
> I first encountered this in the meta-selinux layer but it seemed to
> be
> doing a sensible thing there and then found an example here:
> 
> http://cgit.openembedded.org/cgit.cgi/meta-openembedded/tree/meta-oe/
> recipes-core/plymouth/plymouth_0.9.2.bb?h=master#n16
> 
> That said, there's so few examples like this, I can easily see it
> being
> an error in both spots.

It is incorrect in both cases, we don't support virtual/ in the runtime
namespace. We could change insane.bbclass to check for and error on
this...

Cheers,

Richard