[OE-core] [PATCH 6/6] scripts/contrib/devtool-stress: exclude more recipes by default

Khem Raj raj.khem at gmail.com
Thu Jul 7 04:47:31 UTC 2016


On Wed, Jul 6, 2016 at 7:20 PM, Paul Eggleton
<paul.eggleton at linux.intel.com> wrote:
> On Wed, 06 Jul 2016 18:54:37 Khem Raj wrote:
>> On Wed, Jul 6, 2016 at 6:39 PM, Paul Eggleton
>> <paul.eggleton at linux.intel.com> wrote:
>> > devtool itself already understands not to try to deal with these recipes -
>> > it will print out a reasonable error for the user. The exception list is
>> > just for the devtool-stress script so that it produces clean output.
>>
>> OK understood the case, I was just thinking of cases where recipes are
>> external and for some reason dont yet work with devtool, may be can be
>> blacklisted in recipes
>> instead of having a central list.
>
> Let's break this down a bit:
>
> devtool itself looks at various things to determine whether the recipe can be
> used with "devtool modify" - the implementation is in
> _check_compatible_recipe() in scripts/lib/devtool/standard.py. I don't think
> it would make sense to break this up.
>
> The devtool-stress.py script is just for testing. I'm not even sure if anyone
> else but me actually runs it. To go and put things in a bunch of recipes
> solely for the purpose of this script seems a bit excessive.

OK if devtool has explicit logic for detecting this its fine,
hopefully it will cover
all cases and it can be extended if dubious errors are found over time.

>
> Thinking about it, I guess we could have devtool modify return a particular
> exit code for incompatible recipes and have the stress script consider those
> "skipped" rather than "failed". That to me would be a better alternative.

Certainly it will improve the diagnostics

>
> Cheers,
> Paul
>
> --
>
> Paul Eggleton
> Intel Open Source Technology Centre



More information about the Openembedded-core mailing list