[OE-core] [PATCH] webkitgtk: Switch the ARMv7 build to Thumb2 and enable back the JSC JIT.

[Carlos Alberto Lopez Perez]

On 19/07/16 21:26, Khem Raj wrote:
> On Mon, Jul 18, 2016 at 2:19 PM, Carlos Alberto Lopez Perez
> <clopez at igalia.com> wrote:
>> > * The JSC JIT is broken on ARMv7 without Thumb2.
>> >
>> > [YOCTO #9474]
>> >
>> > Signed-off-by: Carlos Alberto Lopez Perez <clopez at igalia.com>
>> > ---
>> >  meta/recipes-sato/webkit/webkitgtk_2.12.3.bb | 17 ++++++++++++-----
>> >  1 file changed, 12 insertions(+), 5 deletions(-)
>> >
>> > diff --git a/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb b/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb
>> > index c5e5432..536fa23 100644
>> > --- a/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb
>> > +++ b/meta/recipes-sato/webkit/webkitgtk_2.12.3.bb
>> > @@ -71,10 +71,6 @@ EXTRA_OECMAKE_append_armv5 = " -DENABLE_JIT=OFF "
>> >  EXTRA_OECMAKE_append_armv6 = " -DENABLE_JIT=OFF "
>> >  EXTRA_OECMAKE_append_armv4 = " -DENABLE_JIT=OFF "
>> >
>> > -# ARM JIT can build on armv7a, but doesnt' work on runtime, cause
>> > -# displaying problems or ephiphany hang.
>> > -EXTRA_OECMAKE_append_armv7a = " -DENABLE_JIT=OFF "
>> > -
>> >  # binutils 2.25.1 has a bug on aarch64:
>> >  # https://sourceware.org/bugzilla/show_bug.cgi?id=18430
>> >  EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "
>> > @@ -89,7 +85,18 @@ SECURITY_CFLAGS_append_aarch64 = " -fPIE"
>> >  FILES_${PN} += "${libdir}/webkit2gtk-4.0/injected-bundle/libwebkit2gtkinjectedbundle.so"
>> >
>> >  # http://errors.yoctoproject.org/Errors/Details/20370/
>> > -ARM_INSTRUCTION_SET = "arm"
>> > +ARM_INSTRUCTION_SET_armv4 = "arm"
>> > +ARM_INSTRUCTION_SET_armv5 = "arm"
>> > +ARM_INSTRUCTION_SET_armv6 = "arm"
>> > +
>> > +# https://bugzilla.yoctoproject.org/show_bug.cgi?id=9474
>> > +# https://bugs.webkit.org/show_bug.cgi?id=159880
>> > +# JSC JIT can build on ARMv7 with -marm, but doesn't work on runtime.
>> > +# Upstream only tests regularly the JSC JIT on ARMv7 with Thumb2 (-mthumb).
>> > +ARM_INSTRUCTION_SET_armv7a = "thumb"
>> > +ARM_INSTRUCTION_SET_armv7r = "thumb"
>> > +ARM_INSTRUCTION_SET_armv7m = "thumb"
>> > +ARM_INSTRUCTION_SET_armv7ve = "thumb"
> This should be ok. Do we need to specify 'm' ?
> they should be thumb only anyway
> 

Right, good catch..

So I guess is not needed to specify anything for armv7m.

Do you want me to send the patch again without the armv7m line?

Regards.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 883 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160720/17425228/attachment-0002.sig>