[OE-core] [PATCH] rt-tests: rationalise compiler flags

Ross Burton ross.burton at intel.com
Mon Jul 25 20:16:30 UTC 2016


This recipe uses some convoluted methods to ensure the build is using the right
flags but they don't appear to be needed anymore.

No need to prepend HOST_CC_ARCH/TOOLCHAIN_OPTIONS via CFLAGS as the Makefile
picks up CC from the environment and that includes these options.

No need to append the default CFLAGS as their special options are actually in
CPPFLAGS.

Signed-off-by: Ross Burton <ross.burton at intel.com>
---
 meta/recipes-rt/rt-tests/rt-tests.inc    | 3 ---
 meta/recipes-rt/rt-tests/rt-tests_2.0.bb | 4 +---
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/meta/recipes-rt/rt-tests/rt-tests.inc b/meta/recipes-rt/rt-tests/rt-tests.inc
index fd6500b..d832828 100644
--- a/meta/recipes-rt/rt-tests/rt-tests.inc
+++ b/meta/recipes-rt/rt-tests/rt-tests.inc
@@ -5,8 +5,5 @@ SRC_URI = "git://git.kernel.org/pub/scm/utils/rt-tests/rt-tests.git"
 
 S = "${WORKDIR}/git"
 
-# need to append rt-tests' default CFLAGS to ours
-CFLAGS += "-I${S}/src/include -D_GNU_SOURCE -Wall -Wno-nonnull"
-
 # calling 'uname -m' is broken on crossbuilds
 EXTRA_OEMAKE = "NUMA=0"
diff --git a/meta/recipes-rt/rt-tests/rt-tests_2.0.bb b/meta/recipes-rt/rt-tests/rt-tests_2.0.bb
index 83869b8..4336c50 100644
--- a/meta/recipes-rt/rt-tests/rt-tests_2.0.bb
+++ b/meta/recipes-rt/rt-tests/rt-tests_2.0.bb
@@ -15,9 +15,7 @@ SRC_URI += " \
             file://rt_bmark.py \
            "
 # Do not install hwlatdetect
-EXTRA_OEMAKE += "PYLIB='' CROSS_COMPILE=${TARGET_PREFIX}"
-
-CFLAGS_prepend = "${HOST_CC_ARCH}${TOOLCHAIN_OPTIONS}"
+EXTRA_OEMAKE += "PYLIB=''"
 
 do_install() {
         oe_runmake install DESTDIR=${D} SBINDIR=${sbindir} MANDIR=${mandir} \
-- 
2.8.1




More information about the Openembedded-core mailing list