[OE-core] [PATCH 2/3] bitbake.conf: Add P4DIR and FETCHCMD_p4

[Andrew Bradford]

Hi Richard,

On 06/02 16:56, Richard Purdie wrote:
> On Wed, 2016-05-25 at 15:46 -0400, Andrew Bradford wrote:
> > From: Andrew Bradford <andrew.bradford at kodakalaris.com>
> > 
> > So that perforce fetching can work more like the other source control
> > system fetchers.
> > 
> > Signed-off-by: Andrew Bradford <andrew.bradford at kodakalaris.com>
> > ---
> >  meta/conf/bitbake.conf | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > index acef30b..1aa1d37 100644
> > --- a/meta/conf/bitbake.conf
> > +++ b/meta/conf/bitbake.conf
> > @@ -339,6 +339,7 @@ SVNDIR = "${CO_DIR}/svn"
> >  GITDIR = "${CO_DIR}/git2"
> >  BZRDIR = "${CO_DIR}/bzr"
> >  HGDIR = "${CO_DIR}/hg"
> > +P4DIR = "${CO_DIR}/p4"
> >  
> >  STAMPS_DIR ?= "${TMPDIR}/stamps"
> >  STAMP =
> > "${STAMPS_DIR}/${MULTIMACH_TARGET_SYS}/${PN}/${EXTENDPE}${PV}-${PR}"
> > @@ -618,6 +619,7 @@ FETCHCMD_cvs = "/usr/bin/env cvs"
> >  FETCHCMD_wget = "/usr/bin/env wget -t 2 -T 30 -nv --passive-ftp --no
> > -check-certificate"
> >  FETCHCMD_bzr = "/usr/bin/env bzr"
> >  FETCHCMD_hg = "/usr/bin/env hg"
> > +FETCHCMD_p4 = "/usr/bin/env p4"
> 
> I've kind of been hoping we could move to a model where the fetcher has
> sane defaults and we don't need to change anything in bitbake.conf
> unless the user has some need to customise.
> 
> The FETCHCMD is easy to do that for, the P4DIR is slightly harder since
> it means teaching the fetcher about CO_DIR which bitbake currently
> knows nothing about. It may be worth dropping the notion of CO_DIR and
> making the default ${DL_DIR}/p4 which bitbake does know about and
> making the other fetchers match which such defaults?

OK, I'll take a look at that.  It should be easy to have a sane default
for P4DIR and even FETCHCMD_p4 in the fetcher itself and not need
changes to bitbake.conf.

Thanks for the feedback! :)
-Andrew