[OE-core] [PATCH] oe-pkgdata-util: new option to provide full info for binary package(s)

[Alexander Kanevskiy]

On Wed, Jun 8, 2016 at 12:06 AM, Paul Eggleton <
paul.eggleton at linux.intel.com> wrote:

> Hi Sasha,
>
> Functionality wise this looks good.
>
> On Mon, 06 Jun 2016 00:44:29 Alexander D. Kanevskiy wrote:
> > New option can be used for displaying full information about binary
> > package(s), including name, full version, recipe name, recipe full
> version
> > and package size.
> >
> > This information can be useful to produce detailed image manifest
> > for further analysis.
>
> Possibly worth noting that since this looks up current information rather
> than
> what's in the image, this is only going to be accurate for that purpose if
> no
> packages have been rebuilt (strictly speaking no do_packagedata tasks have
> executed) since the manifest was generated.
>

Assumption that it would be used in extra buildhistory class, so pkgdata
still should be valid.
But good point that it can be executed manually.


> > +    for pkg in packages:
> > +        items.append(("%s %s%s%s %s %s%s%s %s" % (
> > +            pkg,
> > +            mappings[pkg]['PKGE'] + ":" if mappings[pkg]['PKGE'] else
> "",
> > +            mappings[pkg]['PKGV'],
> > +            "-" + mappings[pkg]['PKGR'] if mappings[pkg]['PKGR'] else
> "",
> > +            mappings[pkg]['PN'],
> > +            mappings[pkg]['PE'] + ":" if mappings[pkg]['PE'] else "",
> > +            mappings[pkg]['PV'],
> > +            "-" + mappings[pkg]['PR'] if mappings[pkg]['PR'] else "",
> > +            mappings[pkg]['PKGSIZE']
> > +        )).strip()
> > +        )
>
> This seems like a bit of an ugly construction. If it were me writing it I
> would probably break it down using variables rather than trying to do it
> all
> on one line. That said it's not bad enough to block it, if nobody else
> feels
> strongly about it then you're in the clear.
>

ok. I'll send new version of patch a bit later today.

-- 
br, Alexander Kanevskiy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160608/adb9dd14/attachment-0002.html>