[OE-core] [PATCH] depexp.py: port to gtk+3

Richard Purdie richard.purdie at linuxfoundation.org
Fri Jun 17 16:31:16 UTC 2016


On Fri, 2016-06-17 at 17:13 +0100, Richard Purdie wrote:
> On Fri, 2016-06-17 at 17:19 +0300, Maxin B. John wrote:
> > Update depexp.py to support gtk+3
> > 
> > Signed-off-by: Maxin B. John <maxin.john at intel.com>
> > ---
> >  bitbake/lib/bb/ui/depexp.py | 127 ++++++++++++++++++++------------
> > --
> > ----------
> >  1 file changed, 58 insertions(+), 69 deletions(-)
> > 
> > diff --git a/bitbake/lib/bb/ui/depexp.py
> > b/bitbake/lib/bb/ui/depexp.py
> > index 240aafc..8f603dd 100644
> > --- a/bitbake/lib/bb/ui/depexp.py
> > +++ b/bitbake/lib/bb/ui/depexp.py
> > @@ -18,14 +18,15 @@
> >  # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> 
> Thanks for this, it certainly improves something which is currently
> much more broken. I've queued in master-next. Note that this really
> should go to the bitbake list in future.
> 
> I also am a bit worried about the time.sleep(), am seeing if we can
> figure out how to avoid that before it merges...

Looks like its the gtk.init_check() in the bitbake thread before we
setup a separate gtk thread. The check needs to move to the other
thread with appropriate error handling, then we don't need the sleep.

The bitbake main thread needs to likely wait on the gtk init having
finished too.

Cheers,

Richard




More information about the Openembedded-core mailing list