[OE-core] [PATCH] mkefidisk.sh; correct quoting
Christopher Larson
clarson at kergoth.com
Sun Jun 19 23:55:32 UTC 2016
On Sun, Jun 19, 2016 at 2:38 PM, Troy D. Hanson <tdh at tkhanson.net> wrote:
> mkefidisk.sh writes embedded control characters into startup.nsh.
> Causes bootup to fail, dropping user into EFI shell. Encountered while
> following the the Yocto Quick Start example with the Minnowboard Max.
>
> [YOCTO #9665]
>
> Signed-off-by: Troy D. Hanson <tdh at tkhanson.net>
> ---
> scripts/contrib/mkefidisk.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/contrib/mkefidisk.sh b/scripts/contrib/mkefidisk.sh
> index 333284f..a7b17d9 100755
> --- a/scripts/contrib/mkefidisk.sh
> +++ b/scripts/contrib/mkefidisk.sh
> @@ -439,7 +439,7 @@ if [ -d $ROOTFS_MNT/etc/udev/ ] ; then
> fi
>
> # Add startup.nsh script for automated boot
> -echo "fs0:\EFI\BOOT\bootx64.efi" > $BOOTFS_MNT/startup.nsh
> +echo 'fs0:\\EFI\\BOOT\\bootx64.efi' > $BOOTFS_MNT/startup.nsh
>
>
> # Call cleanup to unmount devices and images and remove the TMPDIR
>
We shouldn't be relying on particular unportable behaviors of echo. This
should be replaced with printf for more reliable, predictable behavior.
--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160619/1f530d52/attachment-0002.html>
More information about the Openembedded-core
mailing list