[OE-core] [PATCH 09/10] vte: don't build test app

[Jussi Kukkonen]

On 22 June 2016 at 17:35, Burton, Ross <ross.burton at intel.com> wrote:

> The patch should explain why we're disabling the test application.
>
> If we don't build the test app then the "vte" package is pretty pointless:
>
> libvte:
>         /usr/lib/libvte-2.91.so.0
>         /usr/lib/libvte-2.91.so.0.4400.1
> vte:
>         /etc/profile.d/vte.sh
>         /usr/lib/girepository-1.0/Vte-2.91.typelib
>
> The typelib should be with the library, and that sh fragment is fairly
> pointless.  Should libvte and vte be merged (ie package the library into
> $PN and let the renamer do its job)?
>

Yes, that seems like the right move -- I actually thought vte package was
empty already but on double checking found the same files you did... I'll
resend this patch with changes you suggested .

The reason for disabling was that we aren't using the test application for
anything: matchbox-terminal serves the same purpose.

Jussi


Ross
>
> On 22 June 2016 at 12:52, Jussi Kukkonen <jussi.kukkonen at intel.com> wrote:
>
>> Signed-off-by: Jussi Kukkonen <jussi.kukkonen at intel.com>
>> ---
>>  meta/recipes-support/vte/vte_0.44.1.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-support/vte/vte_0.44.1.bb
>> b/meta/recipes-support/vte/vte_0.44.1.bb
>> index ecbf58a..f3baa1e 100644
>> --- a/meta/recipes-support/vte/vte_0.44.1.bb
>> +++ b/meta/recipes-support/vte/vte_0.44.1.bb
>> @@ -18,7 +18,7 @@ PACKAGECONFIG[gnutls] =
>> "--with-gnutls,--without-gnutls,gnutls"
>>  CFLAGS += "-D_GNU_SOURCE"
>>
>>  # Enable vala only if gobject-introspection is enabled
>> -EXTRA_OECONF = "--enable-vala=auto"
>> +EXTRA_OECONF = "--enable-vala=auto --disable-test-application"
>>
>>  # libtool adds "-nostdlib" when g++ is used. This breaks PIE builds.
>>  # Use libtool-cross (which has a hack to prevent that) instead.
>> --
>> 2.1.4
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>
> ---------------------------------------------------------------------
> Intel Corporation (UK) Limited
> Registered No. 1134945 (England)
> Registered Office: Pipers Way, Swindon SN3 1RJ
> VAT No: 860 2173 47
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160623/5b15c1f5/attachment-0002.html>