[OE-core] [PATCH 04/19] nspr: update to 4.12

[Khem Raj]

On Wed, Mar 2, 2016 at 6:18 AM, Alexander Kanavin
<alexander.kanavin at linux.intel.com> wrote:
> On 03/01/2016 04:58 PM, Khem Raj wrote:
>
>>> The failing patch is applied only when musl is in use (and so the
>>> regression
>>> went unnoticed). Can you rework it so that it can be applied
>>> unconditionally?
>>
>>
>> This probably could be however OE-Core supports musl and poky-tiny
>> defaults to it. It will be good to test
>> changes for it when changing OE-Core at the least bitbake -cpatch <recipe>
>
>
> Yes, but that's a job for autobuilder,

There is a musl job on autobuilder. Not sure if its run daily. Ross ?

I'm afraid. When doing local changes,
> I have to draw the line somewhere about what I test, and what I don't, and
> testing builds against various libc providers is outside of that.

Thats good to please mention that in your patch submissions especially
when you touch a recipe which is using such overrides for anything so
maintainers know testing it has received.

>
> Generally, patches should be unconditional, because a) we should be able to
> send them upstream, b) conditional patches create several slightly different
> versions of source code, which is a maintenance headache.
>

We understand that, sometimes its not possible.