[OE-core] [meta-oe][PATCH] systemd: binfmt should be added to SYSTEMD_PACKAGES

Herve Jourdain herve.jourdain at neuf.fr
Mon Mar 7 15:53:37 UTC 2016


Hmmm… It seems the subject line was cut… It was supposed to say "system: binfmt should be added to SYSTEMD_PACKAGES only if binfmt is enabled".
Yep, the second condition was overkill, I agree.
I'll send a new version of the patch.

Thanks,

Herve

From: Burton, Ross [mailto:ross.burton at intel.com] 
Sent: lundi 7 mars 2016 15:39
To: Herve Jourdain <herve.jourdain at neuf.fr>
Cc: OE-core <openembedded-core at lists.openembedded.org>
Subject: Re: [OE-core] [meta-oe][PATCH] systemd: binfmt should be added to SYSTEMD_PACKAGES

First, the commit message isn't accurate (binfmt was already in SYSTEMD_PACKAGES).

On 7 March 2016 at 14:17, Herve Jourdain <herve.jourdain at neuf.fr> wrote:
-SYSTEMD_PACKAGES = "${PN}-binfmt"
-SYSTEMD_SERVICE_${PN}-binfmt = "systemd-binfmt.service"
+SYSTEMD_PACKAGES = "${@bb.utils.contains('PACKAGECONFIG', 'binfmt',
'${PN}-binfmt', '', d)}"
+SYSTEMD_SERVICE_${PN}-binfmt = "${@bb.utils.contains('PACKAGECONFIG',
'binfmt', 'systemd-binfmt.service', '', d)}"

You don't need to conditionalise SYSTEDM_SERVICE_${PN}-binfmt, just SYSTEMD_PACKAGES.

Ross



More information about the Openembedded-core mailing list