[OE-core] [meta-oe][PATCH] systemd: binfmt should be added to SYSTEMD_PACKAGES only if binfmt is enabled

[Herve Jourdain]

Hi Ross,

 

Duly noted, actually I tried several times through git-send-email, but it didn’t go through… I’m trying to figure out how to have it working in my configuration, but as a last resort I turned to Oulook…

Until I fix my configuration, if I have other patches to send, I’ll follow your suggestion and attach the patch to the email.

 

Thanks,

 

Herve

 

From: Burton, Ross [mailto:ross.burton at intel.com] 
Sent: lundi 7 mars 2016 17:16
To: Herve Jourdain <herve.jourdain at neuf.fr>
Cc: OE-core <openembedded-core at lists.openembedded.org>
Subject: Re: [OE-core] [meta-oe][PATCH] systemd: binfmt should be added to SYSTEMD_PACKAGES only if binfmt is enabled

 

Your mailer (Outlook, by the look of it) is corrupting patches (wraps lines when they shouldn't be wrapped), in the future please don't send patches by pasting them into an email but use git-send-email if you can, or attach the patch if you can't.  For a one-liner I could fix up the patch by hand so you don't need to re-send this one.

 

Ross

 

On 7 March 2016 at 15:59, Herve Jourdain <herve.jourdain at neuf.fr <mailto:herve.jourdain at neuf.fr> > wrote:

V2
Signed-off-by: Herve Jourdain <herve.jourdain at neuf.fr <mailto:herve.jourdain at neuf.fr> >
---
 meta/recipes-core/systemd/systemd_229.bb <http://systemd_229.bb>  | 2 ++--
 1 file changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-core/systemd/systemd_229.bb <http://systemd_229.bb> 
b/meta/recipes-core/systemd/systemd_229.bb <http://systemd_229.bb> 
index 16af0ac..a537dd3 100644
--- a/meta/recipes-core/systemd/systemd_229.bb <http://systemd_229.bb> 
+++ b/meta/recipes-core/systemd/systemd_229.bb <http://systemd_229.bb> 
@@ -298,7 +298,7 @@ PACKAGES =+ "\
     ${PN}-extra-utils \
 "

-SYSTEMD_PACKAGES = "${PN}-binfmt"
+SYSTEMD_PACKAGES = "${@bb.utils.contains('PACKAGECONFIG', 'binfmt', <mailto:$%7b at bb.utils.contains('PACKAGECONFIG',%20'binfmt',%0b'$%7bPN%7d-binfmt',%20'',%20d)%7d> 
'${PN}-binfmt', '', d)}"
 SYSTEMD_SERVICE_${PN}-binfmt = "systemd-binfmt.service"

 USERADD_PACKAGES = "${PN}"
--
1.9.1
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core at lists.openembedded.org <mailto:Openembedded-core at lists.openembedded.org> 
http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core at lists.openembedded.org <mailto:Openembedded-core at lists.openembedded.org> 
http://lists.openembedded.org/mailman/listinfo/openembedded-core

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160308/ef2ee8ad/attachment-0002.html>