[OE-core] [PATCH v2] no-static-libs: Ensure correct whitespace is set for _append

Christopher Larson clarson at kergoth.com
Tue Mar 8 16:57:44 UTC 2016


Just a note that doing it this way will result in do_configure checksums
changing for everything when no-static-libs gets included, even if
DISABLE_STATIC is explicitly set to the empty string, as there'll be a
trailing space always added to EXTRA_OECONF. If that's okay, so be it, but
I wanted to make sure it was considered.

On Mon, Mar 7, 2016 at 4:19 PM Saul Wold <sgw at linux.intel.com> wrote:

> Adjusted white space in the DISABLE_STATIC to make output of the -e
> option more readable.
>
> Before:
>  " --enable-opt1 --with_opt1=${libdir}${DISABLE_STATIC}
> After
>  " --enable-opt1 --with_opt1=${libdir} ${DISABLE_STATIC}
>
> Signed-off-by: Saul Wold <sgw at linux.intel.com>
> ---
> v2: Fixed commit message to show what was getting fixed
>
>  meta/conf/distro/include/no-static-libs.inc | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/conf/distro/include/no-static-libs.inc
> b/meta/conf/distro/include/no-static-libs.inc
> index 6c0f859..0ab99c0 100644
> --- a/meta/conf/distro/include/no-static-libs.inc
> +++ b/meta/conf/distro/include/no-static-libs.inc
> @@ -1,4 +1,4 @@
> -DISABLE_STATIC = " --disable-static"
> +DISABLE_STATIC = "--disable-static"
>
>  # qemu aborts on unrecognised option
>  DISABLE_STATIC_pn-qemu = ""
> @@ -27,6 +27,6 @@ DISABLE_STATIC_pn-nativesdk-openssl = ""
>  # libssp-static-dev included in build-appliance
>  DISABLE_STATIC_pn-gcc-runtime = ""
>
> -EXTRA_OECONF_append = "${DISABLE_STATIC}"
> +EXTRA_OECONF_append = " ${DISABLE_STATIC}"
>
> -EXTRA_OECMAKE_append_pn-libical = "-DSHARED_ONLY=True"
> +EXTRA_OECMAKE_append_pn-libical = " -DSHARED_ONLY=True"
> --
> 2.5.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160308/b79aae30/attachment-0002.html>


More information about the Openembedded-core mailing list