[OE-core] [PATCH RESEND 1/4] ARM: handle missing thumb suffix

Jens Rehsack rehsack at gmail.com
Wed Mar 16 13:18:36 UTC 2016


> Am 16.03.2016 um 13:20 schrieb Phil Blundell <pb at pbcl.net>:
> 
> On Wed, 2016-03-16 at 10:34 +0100, Jens Rehsack wrote:
>> When enabling tune for arm926ejs, poky optionally appends suffixes for
>> thumb and dsp support. Since sometimes arm926ejse (ARM code) and sometime
>> arm926ejste (thumb code) is used in PACKAGE_ARCH, allow both.
> 
> Personally I think this is a further argument for fixing the tune files
> to simply not append these suffixes rather than doubling up the allowed
> architectures everywhere.  See previous discussion on the oe-core list.

Yes, you're invited to send patches. Meanwhile - why does it bother you
a platform (kirkwood) doesn't has build errors anymore by applying that
patch?

> Also, just on a matter of style, if you are submitting a patch to
> oe-core then the description probably oughtn't to refer to things that
> "Poky" does.

Again: Please send me an updated commit message. I tried my best in
digging down where and what is appended to dozen of flags resulting
in proper or weird build behavior.

"All that smells" makes you look wise - but doesn't help in particular
projects :)

Cheers
--
Jens Rehsack - rehsack at gmail.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160316/6fbbb98f/attachment-0002.sig>


More information about the Openembedded-core mailing list