[OE-core] [PATCH v2] base.bbclass wipe ${S} before unpacking source

[Markus Lehtonen]

On 22/03/16 09:47, "Richard Purdie" <richard.purdie at linuxfoundation.org> wrote:


>On Tue, 2016-03-22 at 09:24 +0200, Markus Lehtonen wrote:
>> Make sure that we have a pristine source tree after do_unpack.
>> 
>> [YOCTO #9064]
>> 
>> Signed-off-by: Markus Lehtonen <markus.lehtonen at linux.intel.com>
>> ---
>>  meta/classes/base.bbclass | 12 ++----------
>>  1 file changed, 2 insertions(+), 10 deletions(-)
>> 
>> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
>> index 1372f38..aa107d4 100644
>> --- a/meta/classes/base.bbclass
>> +++ b/meta/classes/base.bbclass
>> @@ -133,23 +133,15 @@ python base_do_fetch() {
>>  
>>  addtask unpack after do_fetch
>>  do_unpack[dirs] = "${WORKDIR}"
>> +do_unpack[cleandirs] = "${@d.getVar('S', True) if d.getVar('S',
>> True) != d.getVar('WORKDIR', True) else ''}"
>
>Should this be else '${S}/patches'?
>
>If we don't do that, there might be a case where we don't clean up the
>patches directory when we could/should compared to the existing code?

Yes, it should. Good catch, thank you Richard!

Cheers,
  Markus